Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust versions for proc-macro2, syn and quote #1269

Closed
wants to merge 2 commits into from
Closed

Adjust versions for proc-macro2, syn and quote #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db003ce
Version adjustments
jayz22 Nov 30, 2023
548005a
allow terminate
jayz22 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cackle.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ allow_unsafe = true
build.allow_apis = [
"env",
"process",
"terminate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit concerning, how come it appeared in the older version of the library and we didn't need it before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look into how this is being used and not sure how concerning this is. But I could roll back to the previous version that doesn't require it.

]
allow_unsafe = true

Expand Down
6 changes: 3 additions & 3 deletions soroban-builtin-sdk-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ rust-version = "1.74"
proc-macro = true

[dependencies]
syn = {version="=2.0.39",features=["full"]}
quote = "=1.0.33"
proc-macro2 = "=1.0.69"
syn = { version = "=2.0.32", features = ["full"] }
quote = "=1.0.30"
proc-macro2 = "=1.0.63"
itertools = "=0.11.0"

[package.metadata.docs.rs]
Expand Down
6 changes: 3 additions & 3 deletions soroban-env-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ proc-macro = true

[dependencies]
stellar-xdr = { workspace = true, features = ["curr", "std"] }
syn = {version="=2.0.39",features=["full"]}
quote = "=1.0.33"
proc-macro2 = "=1.0.69"
syn = { version = "=2.0.32", features = ["full"] }
quote = "=1.0.30"
proc-macro2 = "=1.0.63"
itertools = "=0.11.0"
serde = { version = "=1.0.192", features = ["derive"] }
serde_json = "=1.0.108"
Expand Down