Adjust versions for proc-macro2, syn and quote
#1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Nov 30, 2023
| @@ -266,6 +266,7 @@ allow_unsafe = true | |||
| build.allow_apis = [ | |||
| "env", | |||
| "process", | |||
| "terminate", | |||
There was a problem hiding this comment.
This is a bit concerning, how come it appeared in the older version of the library and we didn't need it before?
There was a problem hiding this comment.
I didn't look into how this is being used and not sure how concerning this is. But I could roll back to the previous version that doesn't require it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
[TODO: Short statement about what is changing.]
Why
To be compatible with core's
cxxKnown limitations
[TODO or N/A]