Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify (and add redundant defensive code) in check_val_integrity #1140

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Clarify (and add redundant defensive code) in check_val_integrity #1140

merged 1 commit into from
Oct 30, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Oct 30, 2023

Fix #1135 (the new code here is not actually dynamically reachable but it's harmless to be extra-paranoid)

@graydon graydon requested a review from sisuresh as a code owner October 30, 2023 21:49
@graydon graydon mentioned this pull request Oct 30, 2023
Closed
@graydon graydon enabled auto-merge October 30, 2023 21:55
@graydon graydon added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 0bbf4b6 Oct 30, 2023
@graydon graydon deleted the bug-1135-clarify-integrity-check-no-boundary-tags branch October 30, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh approved these changes

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_val_integrity does not check for the "Bound" values
3 participants
@graydon @leighmcculloch @sisuresh