Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_val_integrity does not check for the "Bound" values #1135

Closed
jayz22 opened this issue Oct 27, 2023 · 2 comments · Fixed by #1140
Closed

check_val_integrity does not check for the "Bound" values #1135

jayz22 opened this issue Oct 27, 2023 · 2 comments · Fixed by #1140
Assignees
@graydon

Comments

@jayz22
Copy link
Contributor

jayz22 commented Oct 27, 2023

SmallCodeUpperBound, ObjectCodeLowerBound, ObjectCodeUpperBound are not valid Val types to be passed into host. Should probably get filtered along with Bad.
@graydon graydon self-assigned this Oct 30, 2023
@graydon
Copy link
Contributor

graydon commented Oct 30, 2023

These values are mapped to Tag::Bad by Tag::get_tag. I'll rewrite to make this a little more defensive just in case.

@graydon graydon mentioned this issue Oct 30, 2023
Merged
@graydon
Copy link
Contributor

graydon commented Oct 30, 2023

#1140

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@graydon
Clarify (and add redundant defensive code) in check_val_integrity (#1140
0bbf4b6 
)

Fix #1135 (the new code here is not actually dynamically reachable but
it's harmless to be extra-paranoid)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify (and add redundant defensive code) in check_val_integrity stellar/rs-soroban-env
2 participants
@graydon @jayz22