Add name_stable_ptr methods and GetName trait for AST objects

crates/cairo-lang-defs/src/ids.rs

@@ -25,9 +25,9 @@ use cairo_lang_debug::debug::DebugWithDb;
 use cairo_lang_diagnostics::Maybe;
 pub use cairo_lang_filesystem::ids::UnstableSalsaId;
 use cairo_lang_filesystem::ids::{CrateId, FileId};
-use cairo_lang_syntax::node::ast::TerminalIdentifierGreen;
+use cairo_lang_syntax::node::ast::{TerminalIdentifierGreen, TerminalIdentifierPtr};
 use cairo_lang_syntax::node::db::SyntaxGroup;
-use cairo_lang_syntax::node::helpers::{GetIdentifier, NameGreen};
+use cairo_lang_syntax::node::helpers::{GetIdentifier, GetName, NameGreen};
 use cairo_lang_syntax::node::ids::SyntaxStablePtrId;
 use cairo_lang_syntax::node::kind::SyntaxKind;
 use cairo_lang_syntax::node::stable_ptr::SyntaxStablePtr;
@@ -55,9 +55,11 @@ pub trait LanguageElementId {
 
 pub trait NamedLanguageElementLongId {
     fn name(&self, db: &dyn DefsGroup) -> SmolStr;
+    fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr;
 }
 pub trait NamedLanguageElementId: LanguageElementId {
     fn name(&self, db: &dyn DefsGroup) -> SmolStr;
+    fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr;
 }
 pub trait TopLevelLanguageElementId: NamedLanguageElementId {
     fn full_path(&self, db: &dyn DefsGroup) -> String {
@@ -109,11 +111,18 @@ macro_rules! define_named_language_element_id {
                 let terminal_green = self.1.name_green(syntax_db);
                 terminal_green.identifier(syntax_db)
             }
+            fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr {
+                let syntax_db = db.upcast();
+                self.1.lookup(syntax_db).name(syntax_db).stable_ptr()
+            }
         }
         impl NamedLanguageElementId for $short_id {
             fn name(&self, db: &dyn DefsGroup) -> SmolStr {
                 db.$lookup(*self).name(db)
             }
+            fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr {
+                db.$lookup(*self).name_stable_ptr(db)
+            }
         }
     };
 }
@@ -254,6 +263,13 @@ macro_rules! toplevel_enum {
                     )*
                 }
             }
+            fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr {
+                match self {
+                    $(
+                        $enum_name::$variant(id) => id.name_stable_ptr(db),
+                    )*
+                }
+            }
         }
         impl TopLevelLanguageElementId for $enum_name {}
     }
@@ -1192,6 +1208,7 @@ impl ImplItemId {
 }
 
 define_language_element_id_as_enum! {
+    #[toplevel]
     /// Items for resolver lookups.
     /// These are top items that hold semantic information.
     /// Semantic info lookups should be performed against these items.

crates/cairo-lang-syntax/src/node/helpers.rs

@@ -6,9 +6,9 @@ use super::ast::{
     ImplItem, ItemConstant, ItemEnum, ItemExternFunction, ItemExternFunctionPtr, ItemExternType,
     ItemImpl, ItemImplAlias, ItemInlineMacro, ItemModule, ItemStruct, ItemTrait, ItemTypeAlias,
     ItemUse, Member, Modifier, ModuleItem, OptionArgListParenthesized, Statement, StatementBreak,
-    StatementContinue, StatementExpr, StatementLet, StatementReturn, TerminalIdentifierGreen,
-    TokenIdentifierGreen, TraitItem, TraitItemConstant, TraitItemFunction, TraitItemFunctionPtr,
-    TraitItemImpl, TraitItemType, UsePathLeaf, Variant, WrappedArgList,
+    StatementContinue, StatementExpr, StatementLet, StatementReturn, TerminalIdentifier,
+    TerminalIdentifierGreen, TokenIdentifierGreen, TraitItem, TraitItemConstant, TraitItemFunction,
+    TraitItemFunctionPtr, TraitItemImpl, TraitItemType, UsePathLeaf, Variant, WrappedArgList,
 };
 use super::db::SyntaxGroup;
 use super::ids::SyntaxStablePtrId;
@@ -156,6 +156,39 @@ impl NameGreen for TraitItemFunctionPtr {
     }
 }
 
+/// Provides methods to extract a _name_ of AST objects.
+pub trait GetName {
+    /// Gets a [`TerminalIdentifier`] that represents a _name_ of this AST object.
+    fn name(&self, db: &dyn SyntaxGroup) -> ast::TerminalIdentifier;
+}
+
+impl GetName for FunctionWithBody {
+    fn name(&self, db: &dyn SyntaxGroup) -> TerminalIdentifier {
+        self.declaration(db).name(db)
+    }
+}
+
+impl GetName for ItemExternFunction {
+    fn name(&self, db: &dyn SyntaxGroup) -> TerminalIdentifier {
+        self.declaration(db).name(db)
+    }
+}
+
+impl GetName for TraitItemFunction {
+    fn name(&self, db: &dyn SyntaxGroup) -> TerminalIdentifier {
+        self.declaration(db).name(db)
+    }
+}
+
+impl GetName for UsePathLeaf {
+    fn name(&self, db: &dyn SyntaxGroup) -> TerminalIdentifier {
+        match self.alias_clause(db) {
+            ast::OptionAliasClause::Empty(_) => self.ident(db).identifier_ast(db),
+            ast::OptionAliasClause::AliasClause(alias) => alias.alias(db),
+        }
+    }
+}
+
 pub trait GenericParamEx {
     /// Returns the name of a generic param if one exists.
     fn name(&self, db: &dyn SyntaxGroup) -> Option<ast::TerminalIdentifier>;