Add name_stable_ptr methods and GetName trait for AST objects

[mkaput]

CairoLS needs to check whether an arbitrary TerminalIdentifier is a name of a given NamedLanguageElementId. This would be pretty tedious to implement downstream, while it is trivial to embed in the define_* macros we have here.

[reviewable-StarkWare]

This change is 

[mkaput]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @orizi)

---

a discussion (no related file):
@orizi if possible, I'd like to get this cherry-picked to 2.10. I need this to fix bugs in goto-definition implementation.

[orizi]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions

---

crates/cairo-lang-syntax/src/node/helpers.rs line 152 at r1 (raw file):

/// Provides methods to extract a _name_ of AST objects.
pub trait GetName {

Suggestion:

/// Provides methods to extract a _name_ of AST objects.
pub trait HasName {

---

crates/cairo-lang-defs/src/ids.rs line 58 at r1 (raw file):

pub trait NamedLanguageElementLongId {
    fn name(&self, db: &dyn DefsGroup) -> SmolStr;
    fn name_stable_ptr(&self, db: &dyn DefsGroup) -> TerminalIdentifierPtr;

will this work?

Suggestion:

    fn name_identifier(&self, db: &dyn DefsGroup) -> TerminalIdentifier;

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mkaput)

[mkaput]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-defs/src/ids.rs line 58 at r1 (raw file):

Previously, orizi wrote…

will this work?

yes, it will. I stuck with stable ptrs because that's what I compare + I have originally been returning untyped stable ptrs because I wanted to reserve space for elements named after non-identifiers (like keywords) which kinda doesn't make sense in retrospective.

Done

---

crates/cairo-lang-syntax/src/node/helpers.rs line 152 at r1 (raw file):

/// Provides methods to extract a _name_ of AST objects.
pub trait GetName {

Done.

[orizi]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)