-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dependency cleanup pre-cargo-vet
#1271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cylewitruk
added
tech debt
chore
dependencies
Pull requests that update a dependency file
labels
Jan 25, 2025
cylewitruk
commented
Jan 25, 2025
cylewitruk
commented
Jan 25, 2025
cylewitruk
commented
Jan 25, 2025
cylewitruk
commented
Jan 26, 2025
matteojug
approved these changes
Jan 28, 2025
matteojug
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
4 tasks
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I decided to spend my Saturday cleaning up our dependencies before we start using
cargo vet
more seriously. Things have gotten a little "messy" through the crunching.ℹ️ The PR looks big, but the majority is
Cargo.lock
andcargo vet
config:Changes
Summary
Cargo.toml
:workspace = true
.default-features = false
and only necessary features explicitly enabled.semver
(i.e.x.x.x
).mockito
, see below).cargo-vet
have been updated.cargo
commands in theMakefile
now use--locked
.More Details
cargo machete --with-metadata
to help me find unused dependencies. False-positives were added to crates'Cargo.toml
under the[package.metadata.cargo-machete]
stanza -- it seems less smart when it comes to build- and git-deps.default-features = false
for each workspace member dependency, but I tested this and workspace members do seem to inherit this configuration even though the docs say it implicitly enables it 🤷 So I've removed it from workspace members.cargo vet
config as exclusions, I figure that from here on out, we should actually make attempts at auditing the changes when we update dependencies viacargo vet audit
so that it's recorded.--locked
now becomes pretty important unless you're explicitly trying to upgrade things as there's no guarantee that our dependencies don't specify justx
orx.y
for their dependencies.cargo sort -g -w
to sort and make theCargo.toml
files consistent in formatting.Dependency Upgrade Notes
fake
can't be upgraded>2.9.2
as it causes a problem with one of the withdrawal integration tests.config
can't be upgraded>0.14.1
due to changes in how it reports errors which breaks a number of tests.secp256k1
can't be upgraded>0.29.0
due to conflict in bitcoin .reqwest
can't be upgraded>0.11.27
due to breaking changes.hashbrown
can't be upgraded past>0.14.5
due to version conflicts with fake/dummy among others.utoipa
can't be upgraded past>4.2.3
due to breaking changes.libp2p
updates are duplicated from feat: new behavior for network bootstrapping #1257.mockito
version consolidation required changes inblocklist-client
due to having used a much older version, so that's why there's some larger changes there. Please give this some 👀 -- these were not usingMock::assert()
previously which after adding them revealed some errors in the tests.thiserror
upgrade required a minor formatting change insigner/src/error.rs
.prost
upgrade renamed one function used insigner/build.rs
.Testing Information
For each dependency bump, I did the following to find & ensure no issues:
All tests pass both locally and in CI. I also ensured that
devenv
works as expected.Checklist: