Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the same sorting key for in memory impl of stacks chain tip #1282

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

matteojug
Copy link
Collaborator

Description

Fix a difference between the in memory and pg implementation of get_stacks_chain_tip, follow up for the broken test after the fake (non) bump in #1271.

Changes

Bump fake and fix the in memory implementation of get_stacks_chain_tip to align it to the pg implementation, by changing the endianness of the stacks block hash used for tie breaking.

Testing Information

The "broken" test now passes, and add two test to compare the get chain tip between the pg and in memory stores.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@matteojug matteojug requested review from cylewitruk and djordon and removed request for cylewitruk January 29, 2025 02:27
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@matteojug matteojug merged commit bcab2dd into main Jan 29, 2025
8 checks passed
@matteojug matteojug deleted the fix/stacks-chain-tip-in-memory-impl branch January 29, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants