Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing signers' votes #1243

Merged
merged 17 commits into from
Jan 29, 2025
Merged

fix: missing signers' votes #1243

merged 17 commits into from
Jan 29, 2025

Conversation

Jiloc
Copy link
Collaborator

@Jiloc Jiloc commented Jan 20, 2025 •
edited
Loading

Description

Closes: #1237

Changes

  • add new deposit_decisions_retry_window param to the signers' settings (defaults to 3)
  • add query to get the all the DepositSigner entries from the DB from the last N blocks
  • add resend mechanism in the request_decider to resend all the Requests of the last 3 blocks when a new bitcoin block arrives

Testing Information

  • add query integration tests

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Jiloc Jiloc self-assigned this Jan 20, 2025
Jiloc
Jiloc commented Jan 20, 2025
View reviewed changes
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
@Jiloc Jiloc mentioned this pull request Jan 20, 2025
Merged
3 tasks
matteojug
matteojug reviewed Jan 22, 2025
View reviewed changes
signer/src/request_decider.rs Outdated Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
signer/src/storage/postgres.rs Outdated Show resolved Hide resolved
signer/src/request_decider.rs Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
matteojug
matteojug approved these changes Jan 28, 2025
View reviewed changes
signer/src/storage/in_memory.rs Outdated Show resolved Hide resolved
signer/src/testing/storage/model.rs Outdated Show resolved Hide resolved
signer/src/request_decider.rs Outdated Show resolved Hide resolved
signer/src/testing/storage/model.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
@Jiloc Jiloc merged commit 1fec105 into main Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteojug matteojug matteojug approved these changes

@djordon djordon Awaiting requested review from djordon

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

Assignees

@Jiloc Jiloc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Signer Votes
2 participants
@Jiloc @matteojug