-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sleep after new block to the request_decider #1246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Let's wait to get more eyes on this before merging, in case there is some edge case that we're blanking on that would make this a bad idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out loud: assuming everyone gets the bitcoin block at exactly the same time, with the sleep as is here we may risk having the coordinator starting the round before the decisions manage to get to it (like, everyone broadcast its own decision, then the coordinator starts but it only has its own decision).
I think this is slightly worse than before, but it could be equivalent.
How about we separate the two timeouts: one in the RequestDecider after a new block, and another in the TxCoordinator after receiving the signal from the RequestDecider? We could set them both to 15 seconds. While this isn't an ideal or final solution, I believe it's a reasonable compromise. It should still allow us to receive the decisions and blocks in time most of the time. #1243 will remain the final solution. And if we implement a filter to only resend messages that didn't receive all replies, we could significantly reduce the number of repeated messages. |
Co-authored-by: Matteo Almanza <[email protected]>
Co-authored-by: Matteo Almanza <[email protected]>
Co-authored-by: Matteo Almanza <[email protected]>
Description
Part of : #1237
Changes
requests_processing_delay
to the request_decider. This will give additional time to the bitcoin nodes to get in sync before receiving the vote decisions from the signers.Checklist: