Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override of performBatchUpdates, it causes warnings for consumers #512

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Remove override of performBatchUpdates, it causes warnings for consumers #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

### Internal

- Remove override of `performBatchUpdates` from our internal `UICollectionView` subclass, it causes warnings for consumers.

# Past Releases

# [13.0.0] - 2023-09-06
Expand Down
5 changes: 0 additions & 5 deletions ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,6 @@ extension ListView {

required init?(coder: NSCoder) { fatalError() }

@available(*, unavailable, message: "Please use performBatchUpdates:changes:completion:.")
override func performBatchUpdates(_ updates: (() -> Void)?, completion: ((Bool) -> Void)? = nil) {
super.performBatchUpdates(updates, completion: completion)
}

func performBatchUpdates(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: It might be worth adding some doc comments to this method since the normal performBatchUpdates will now show up in things like autocomplete results (and might help avoid any accidental invocation).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super worried about this; this method is only called in one place in the entire codebase (by design).

_ updates: @escaping () -> Void,
changes : CollectionViewChanges,
Expand Down
Loading