Remove override of performBatchUpdates, it causes warnings for consumers #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmaceachern
approved these changes
Nov 22, 2023
| override func performBatchUpdates(_ updates: (() -> Void)?, completion: ((Bool) -> Void)? = nil) { | ||
| super.performBatchUpdates(updates, completion: completion) | ||
| } | ||
|
|
||
| func performBatchUpdates( |
There was a problem hiding this comment.
Minor: It might be worth adding some doc comments to this method since the normal performBatchUpdates will now show up in things like autocomplete results (and might help avoid any accidental invocation).
There was a problem hiding this comment.
I'm not super worried about this; this method is only called in one place in the entire codebase (by design).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a way to represent
NS_NOESCAPEin Swift here... Just going to remove this override since it's an entirely internal type anyway.Checklist
Please do the following before merging:
Mainsection.