Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork PR #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

var Admin = {

collectionCounters: [],
lolCounters: [],
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Unquoted property 'lolCounters' found.


/**
* This function must be called when an ajax call is done, to ensure
Expand Down Expand Up @@ -321,7 +321,7 @@ var Admin = {
counter = parseInt(matches[1], 10);
}
});
Admin.collectionCounters[collection.attr('id')] = counter;
Admin.lolCounters[collection.attr('id')] = counter;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Strings must use doublequote.

});
},

Expand All @@ -331,7 +331,7 @@ var Admin = {
Admin.stopEvent(event);

var container = jQuery(this).closest('[data-prototype]');
var counter = ++Admin.collectionCounters[container.attr('id')];
var counter = ++Admin.lolCounters[container.attr('id')];
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Combine this with the previous 'var' statement.
  • eslint: Unexpected var, use let or const instead.
  • eslint: All 'var' declarations must be at the top of the function scope.
  • eslint: Unary operator '++' used.
  • eslint: Strings must use doublequote.

var proto = container.attr('data-prototype');
var protoName = container.attr('data-prototype-name') || '__name__';
// Set field id
Expand Down
2 changes: 1 addition & 1 deletion con:fig.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
test: 'toto'
test: @toto
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token

2 changes: 1 addition & 1 deletion config.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
test: 'toto'
test: @toto
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token

2 changes: 2 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
const test = "toto";
console.log(test);

const toto = "kikou";
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Combine this with the previous 'const' statement.
  • eslint: 'toto' is assigned a value but never used.

8 changes: 6 additions & 2 deletions test.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php
<?php echo 'test';

$arr = array(
'toto' => 'titi',
'toto' => 'titi',
);

if (true) {
} else if (false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage of ELSE IF is discouraged; use ELSEIF instead

}
1 change: 1 addition & 0 deletions toto/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
test: @toto
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token