Fork PR #6
Open
Fork PR #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 13, 2017
| ); | ||
|
|
||
| if (true) { | ||
| } else if (false) { |
There was a problem hiding this comment.
Usage of ELSE IF is discouraged; use ELSEIF instead
soullivaneuh
commented
Oct 13, 2017
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| var Admin = { | |||
|
|
|||
| collectionCounters: [], | |||
| lolCounters: [], | |||
There was a problem hiding this comment.
- eslint: Unquoted property 'lolCounters' found.
soullivaneuh
commented
Oct 13, 2017
| @@ -321,7 +321,7 @@ var Admin = { | |||
| counter = parseInt(matches[1], 10); | |||
| } | |||
| }); | |||
| Admin.collectionCounters[collection.attr('id')] = counter; | |||
| Admin.lolCounters[collection.attr('id')] = counter; | |||
There was a problem hiding this comment.
- eslint: Strings must use doublequote.
soullivaneuh
commented
Oct 13, 2017
| @@ -331,7 +331,7 @@ var Admin = { | |||
| Admin.stopEvent(event); | |||
|
|
|||
| var container = jQuery(this).closest('[data-prototype]'); | |||
| var counter = ++Admin.collectionCounters[container.attr('id')]; | |||
| var counter = ++Admin.lolCounters[container.attr('id')]; | |||
There was a problem hiding this comment.
- eslint: Combine this with the previous 'var' statement.
- eslint: Unexpected var, use let or const instead.
- eslint: All 'var' declarations must be at the top of the function scope.
- eslint: Unary operator '++' used.
- eslint: Strings must use doublequote.
soullivaneuh
commented
Oct 13, 2017
| @@ -1 +1 @@ | |||
| test: 'toto' | |||
| test: @toto | |||
There was a problem hiding this comment.
- yamllint: syntax error: found character '@' that cannot start any token
soullivaneuh
commented
Oct 13, 2017
| @@ -1 +1 @@ | |||
| test: 'toto' | |||
| test: @toto | |||
There was a problem hiding this comment.
- yamllint: syntax error: found character '@' that cannot start any token
soullivaneuh
commented
Oct 13, 2017
| @@ -1,2 +1,4 @@ | |||
| const test = "toto"; | |||
| console.log(test); | |||
|
|
|||
| const toto = "kikou"; | |||
There was a problem hiding this comment.
- eslint: Combine this with the previous 'const' statement.
- eslint: 'toto' is assigned a value but never used.
soullivaneuh
commented
Oct 13, 2017
| @@ -0,0 +1 @@ | |||
| test: @toto | |||
There was a problem hiding this comment.
- yamllint: syntax error: found character '@' that cannot start any token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.