[dhcp_relay] Remove skip dhcp_relay test when dhcp_server is enabled #16608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
changed the title
Blueve
approved these changes
Jan 22, 2025
|
Hi @yxieca @kperumalbfn @bingwang-ms could you please help to approve the backport request? |
yaqiangz
added
Approved for 202311 branch
and removed
Approved for 202311 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 23, 2025
…onic-net#16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
|
Cherry-pick PR to 202311: #16650 |
Merged
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 23, 2025
…onic-net#16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
|
Cherry-pick PR to 202411: #16653 |
Merged
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 23, 2025
…16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jan 23, 2025
…16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 24, 2025
…onic-net#16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
|
Cherry-pick PR to 202405: #16667 |
Merged
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 25, 2025
…16608) What is the motivation for this PR? This skip condition would take effect on all test cases under dhcp_relay folder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled. And dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server How did you do it? Remove skip check How did you verify/test it? Run tests
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This skip condition would take effect on all test cases under
dhcp_relayfolder, which would skip dhcpv6_relay tests too. But we don't want to skip it when dhcp_server is enabled.When dhcp_server is enabled, dhcpv4_relay would be disabled, and dhcpv4_relay test is only running in m0 and t0, which wouldn't enable dhcp_server
How did you do it?
Remove skip check
How did you verify/test it?
Run tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation