Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new WebView Interface #913

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Add new WebView Interface #913

merged 11 commits into from
Jan 16, 2025

Conversation

mscwilson
Copy link
Contributor

This PR is part of our upgrade to the Snowplow WebView tracker. It allows the tracking of all web events, including certain base/primitive event properties.

Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give this a deeper review when I come back from vacation, but looks good!

Sources/Core/Tracker/TrackerEvent.swift Outdated Show resolved Hide resolved
Sources/Snowplow/Snowplow.swift Outdated Show resolved Hide resolved
Sources/Core/Tracker/WebViewMessageHandlerV2.swift Outdated Show resolved Hide resolved
Sources/Core/Tracker/WebViewMessageHandlerV2.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mscwilson mscwilson merged commit 4c8ff6b into release/6.1.0 Jan 16, 2025
9 of 14 checks passed
@mscwilson mscwilson deleted the new_webview_interface branch January 16, 2025 14:25
@mscwilson mscwilson mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants