Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/6.1.0 #915

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Release/6.1.0 #915

merged 3 commits into from
Jan 20, 2025

Conversation

mscwilson
Copy link
Contributor

This version makes tracking in hybrid apps easier and more powerful, by adding support for the new Snowplow JavaScript tracker WebView plugin (available from JS tracker v4.3).

Implement the JS tracker plus WebView plugin in your WebView to automatically forward all web events to the iOS tracker.

Enhancements

Under the hood

* Start adding new webview classes

* Add tests

* Parse the webview message

* Make one of the tests work

* Make more tests work

* Make all tests pass

* Refactor message handler

* Add subscription to Snowplow main class

* Update based on review comments

* Remove unnecessary null checks

* Add an error log if the namespace doesn't exist
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a nitpick, but it'd be nice to also run pod install in the 2 cocoapods example apps – doesn't do much, just updates the lockfile, you can see other release commits for inspiration

@mscwilson mscwilson merged commit a6bcc21 into master Jan 20, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants