Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp #2830

Merged
merged 9 commits into from
Jan 14, 2025
Merged

SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp #2830

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4ee1af8
SNOW-1874368: skip cortex sentiment doctest if running in gcp
sfc-gh-lmukhopadhyay Jan 7, 2025
0131db9
add pytest import
sfc-gh-lmukhopadhyay Jan 7, 2025
019ab2f
Merge branch 'main' into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
sfc-gh-lmukhopadhyay Jan 7, 2025
1369c59
remove docstr example
sfc-gh-lmukhopadhyay Jan 8, 2025
21d3ffe
Merge branch 'lmukhopadhyay-SNOW-1874368-skip-cortex-doctests' of git…
sfc-gh-lmukhopadhyay Jan 8, 2025
a4609a7
Merge branch 'main' into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
sfc-gh-lmukhopadhyay Jan 8, 2025
ac9afab
Merge branch 'main' into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
sfc-gh-lmukhopadhyay Jan 9, 2025
2ea3bbd
Merge branch 'main' into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
sfc-gh-jrose Jan 14, 2025
37b5993
Merge branch 'main' into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
sfc-gh-lmukhopadhyay Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/snowflake/snowpark/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10447,6 +10447,9 @@ def snowflake_cortex_sentiment(text: ColumnOrLiteralStr):

Example::

>>> import pytest
>>> if session.connection.host == "sfctest0.us-central1.gcp.snowflakecomputing.com":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples end up in our public facing docs. I'm not sure we want to have conditionals like this show up there.

Copy link
Contributor Author

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-jrose In that case, it might be better to remove this docstring example entirely

... pytest.skip()
>>> content = "A very very bad review!"
>>> df = session.create_dataframe([[content]], schema=["content"])
>>> result = df.select(snowflake_cortex_sentiment(content)).collect()[0][0]
Expand Down
Loading