Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp #2830

Merged

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay commented Jan 7, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1874368 and failing daily precommit test.
    Daily test result with no snowflake_cortex_sentiment failures: https://github.com/snowflakedb/snowpark-python/actions/runs/12658208865/job/35274782725

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Fix for daily precommit test snowflake_cortex_sentiment doctest failures (Snowpark python daily github action test)

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Jan 7, 2025
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review January 7, 2025 21:29
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested review from a team as code owners January 7, 2025 21:29
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay changed the title SNOW-1874368: Skip cortex sentiment doctest in gcp SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp Jan 7, 2025
@@ -10447,6 +10447,9 @@ def snowflake_cortex_sentiment(text: ColumnOrLiteralStr):

Example::

>>> import pytest
>>> if session.connection.host == "sfctest0.us-central1.gcp.snowflakecomputing.com":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples end up in our public facing docs. I'm not sure we want to have conditionals like this show up there.

Copy link
Contributor Author

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-jrose In that case, it might be better to remove this docstring example entirely

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 9d430e4 into main Jan 14, 2025
42 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1874368-skip-cortex-doctests branch January 14, 2025 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants