-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp #2830
SNOW-1874368: Skip snowflake_cortex_sentiment doctest in gcp #2830
Conversation
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
src/snowflake/snowpark/functions.py
Outdated
@@ -10447,6 +10447,9 @@ def snowflake_cortex_sentiment(text: ColumnOrLiteralStr): | |||
|
|||
Example:: | |||
|
|||
>>> import pytest | |||
>>> if session.connection.host == "sfctest0.us-central1.gcp.snowflakecomputing.com": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples end up in our public facing docs. I'm not sure we want to have conditionals like this show up there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-jrose In that case, it might be better to remove this docstring example entirely
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
…hub.com:snowflakedb/snowpark-python into lmukhopadhyay-SNOW-1874368-skip-cortex-doctests
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1874368 and failing daily precommit test.
Daily test result with no snowflake_cortex_sentiment failures: https://github.com/snowflakedb/snowpark-python/actions/runs/12658208865/job/35274782725
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Fix for daily precommit test
snowflake_cortex_sentiment
doctest failures (Snowpark python daily github action test)