This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Add support for TCP connections (as introduced in etsy/statsd@v0.8.0) #67
+677
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, including unit tests
…from the Travis CI build and adding Node 4, 5, 6 and 7 :)
Adding documentation on `tcp` option and updating reference to supported NodeJS versions
|
This project hasn't been updated in years. If you'd like to submit to https://github.com/brightcove/hot-shots I'll look it over there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TCP connections, which was included in the
etsy/statsdlibrary in version 0.8.0 (current). It adds a boolean 'tcp' option. If set to true, it will create a net.Socket connection with keepAlive enabled to the specified host/port. Stats are written to the TCP socket for processing by Statsd.The unit tests have been updated to also include a TCP server test, with TCP server implementation taken from
etsy/statsd.