Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TCP connections #76

Closed
honzajavorek opened this issue Jul 2, 2018 · 1 comment
Closed

Add support for TCP connections #76

honzajavorek opened this issue Jul 2, 2018 · 1 comment

Comments

@honzajavorek
Copy link

Thanks for this library! It took me a while to stumble upon it (not really intuitive name, I guess all have been taken), but the greater is the joy a maintained statsd library exists! And it even mentions Telegraf, which I'd like to use ❤️

The only thing I'm missing is a TCP connection support as laid out in sivy/node-statsd#67. What would be the best way to help the TCP support to arrive?

I could obviously try to copy-paste @remie's PR to this repository, keeping him as the author of the commits, if that's the only thing missing and he agrees with it...

@bdeitte
Copy link
Collaborator

bdeitte commented Jul 2, 2018

If you brought over that PR, that sounds great. I don't think copy-pasting the code over will work exactly, as there has been some splitting of the one main file into more than one here. But it shouldn't be too much extra work. While I am not actively developing in this project, I'm quick to review and merge things in.

And you are right as mentioned in that other PR- this hasn't brought into this project yet. There is another related outstanding issue as well with #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants