doc: add upgrade information for Pinia migration #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajespasarela
force-pushed
the
next-40449/add-upgrade-doc-for-pinia
branch
6 times, most recently
from
6e5322a to
29be204
Compare
jleifeld
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Looks really good. The only thing I'm thinking about is explaining the case how to implement the composables outside the store (which are then added again into a store) so that they are directly accessible even when Pinia isn't initialized yet.
This could be useful especially for internal developer
tajespasarela
force-pushed
the
next-40449/add-upgrade-doc-for-pinia
branch
3 times, most recently
from
823612b to
a9de0c5
Compare
tajespasarela
force-pushed
the
next-40449/add-upgrade-doc-for-pinia
branch
from
a9de0c5 to
e25a1bb
Compare
@jleifeld done! |
jleifeld
approved these changes
Jan 28, 2025
Isengo1989
approved these changes
Jan 28, 2025
seggewiss
approved these changes
Jan 30, 2025
|
@tajespasarela should this be merged already or tagged for milestone 6.7 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about the migration from Vuex to Pinia and explains how to proceed.