Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support
#[serde(validate = "function")]
for container, compatible withvalidator
crate #2891base: master
Are you sure you want to change the base?
Support
#[serde(validate = "function")]
for container, compatible withvalidator
crate #2891Changes from 8 commits
780b391
b82d4a9
da1d396
b5febd6
77f2f67
cb2cf61
e611d5f
26580d5
2409f74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it is better to use
From
trait here and below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the signature of validation should be
fn <E: serde::de::Error>(&T) -> Result<(), impl Into<E>>
?In this case, if we want to call
#[serde(validate = "validator::Validate::validate")]
to usevalidator
, the only way is to add follow code withinserde
, since Rust only allow local impl fortrait E
It will introduce a new dependence for
serde
, I don't know if we can do thatWell, there are only
serde::de::Error::cutom
andserde::de::Error::invalid_value
that are suitable for validation, I think just useserde::de::Error::cutom
is a good approach :)