-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support #[serde(validate = "function")]
for container, compatible with validator
crate
#2891
Open
zao111222333
wants to merge
9
commits into
serde-rs:master
Choose a base branch
from
zao111222333:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
780b391
Support `#[serde(validate = "some_function")]` for container, compati…
zao111222333 b82d4a9
remove the underline of `__body`
zao111222333 da1d396
Update serde_derive/src/de.rs
zao111222333 b5febd6
fix typo
zao111222333 77f2f67
fix serde_path
zao111222333 cb2cf61
support `#[serde(validator)]`
zao111222333 e611d5f
support multi validations
zao111222333 26580d5
format quote
zao111222333 2409f74
fix typo
zao111222333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it is better to use
From
trait here and below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the signature of validation should be
fn <E: serde::de::Error>(&T) -> Result<(), impl Into<E>>
?In this case, if we want to call
#[serde(validate = "validator::Validate::validate")]
to usevalidator
, the only way is to add follow code withinserde
, since Rust only allow local impl fortrait E
It will introduce a new dependence for
serde
, I don't know if we can do thatWell, there are only
serde::de::Error::cutom
andserde::de::Error::invalid_value
that are suitable for validation, I think just useserde::de::Error::cutom
is a good approach :)