chore: add CI tests for the pre-commit hooks #9
Conversation
There was a problem hiding this comment.
Approving since this seems better than nothing, but I am not sure of the approach (for instance, I don't love doing it in the same git repo; I would prefer making a fresh one as part of the test).
I would probably also prefer us to have a script or Makefile which CI uses instead of scripting it directly there.
| - repo: https://github.com/semgrep/pre-commit | ||
| rev: 'v1.76.0' |
There was a problem hiding this comment.
| - repo: https://github.com/semgrep/pre-commit | |
| rev: 'v1.76.0' | |
| - repo: local |
Can we just make this a local hook so it is testing the current configuration, rather than being a pointer to potentially something else?
There was a problem hiding this comment.
Looks like I can't just swap in local and there's more config fields that I need to understand. I'm gonna give up on trying that for now.
There was a problem hiding this comment.
It may not be supported for the Python ones. Not sure.
ETA: Oh I see. Yeah, I don't like this, but that's more complex than I thought.
This PR adds a pre-commit hook config. The new CI workflow installs the hook and then runs it.
The workflow just fakes a change
git mv tests/python_simple.py python_simple.py, so pre-commit can pick it up.Currently points to 1.76.0 which is the newest available tag at the moment.
For each new release, the hook should be updated after updating the release tag. Could probably be automated somewhat, but going to do that manually for now.