Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.77.0 and 1.78.0 #8

Merged
merged 2 commits into from
Jul 2, 2024
Merged

chore: release 1.77.0 and 1.78.0 #8

merged 2 commits into from
Jul 2, 2024

Conversation

amchiclet
Copy link
Contributor

@amchiclet amchiclet commented Jul 1, 2024

  • tag(s) created post-merge (this PR has 2 commits)

@kopecs
Copy link
Collaborator

kopecs commented Jul 1, 2024

We can do 1.78.0 in this one as well if you want (with a rebase merge).

@amchiclet
Copy link
Contributor Author

Yes, I'll commit 1.78.0 on this PR too. Thanks!

@amchiclet amchiclet marked this pull request as ready for review July 2, 2024 00:16
@amchiclet amchiclet requested a review from kopecs July 2, 2024 00:16
Copy link
Collaborator

@kopecs kopecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just do a rebase merge

@amchiclet amchiclet merged commit d2b0ee9 into develop Jul 2, 2024
2 checks passed
@kopecs
Copy link
Collaborator

kopecs commented Jul 2, 2024

Oh it seems like the workflow from #9 may be annoying. Given we now have to (1) update the CI job tag reference; (2) create the tags for these; (3) manually run it (Since it has a dependency on the tags being created).

@amchiclet amchiclet changed the title chore: release 1.77.0 chore: release 1.77.0 and 1.78.0 Jul 2, 2024
@amchiclet
Copy link
Contributor Author

So true. I was thinking we need to create tags first, then update the CI job tag. I wanna automate this if possible.

@kopecs
Copy link
Collaborator

kopecs commented Jul 2, 2024

Ideally CI doesn't need a tag IMO, and it can just do it on what is present at that version. Agree for sure about automating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants