add a flag to spoiler unit names #45
Conversation
|
@Dr-zzt does this look good?
|
|
so, my three thoughts on this specific implementation is that the 'SPOILER' text won't be translated, because it is returned from the back-end like that. Not sure if that is a huge issue or not, it kinda looks bad I think. The other issue is that the spoiler flag only applies after a page reload (because the spoilering is done server-side). You could do the spoilering clientside which would give you the ability to translate it, as well as have it take effect instantly but then it would be easy to see the unit names in the network panel. The third issue I can see with this implementation is it still shows you which unit names have non-defaults (they will still appear in the unit name list), not sure if that will give away too much info? |
|
I think this is fine for an initial version of the feature. Thank you for implementing this! |
fixes #42