Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjsf typing is slow #1663

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Rjsf typing is slow #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e58041
updated rjsf packages w/ burnettk
jasquat Jun 3, 2024
a08061d
use performance improvement branch of validate js v8 w/ burnettk
jasquat Jun 3, 2024
8b511d2
Update spiffworkflow-backend/bin/task_data_to_python_variables.py
burnettk Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions spiffworkflow-backend/bin/task_data_to_python_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import json
import sys

from spiffworkflow_backend import create_app


def main() -> None:
app = create_app()
task_data_json_file = sys.argv[1]
python_variable_file = f"{task_data_json_file}_output.py"

with app.app_context():
contents = None
with open(task_data_json_file) as file:
contents = json.load(file)

with open(python_variable_file, "w") as file:
for key, value in contents.items():
file.write(f"{key} = {repr(value)}\n")


if len(sys.argv) < 2:
raise Exception("A task data json file must be provided")

if __name__ == "__main__":
main()
69 changes: 34 additions & 35 deletions spiffworkflow-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions spiffworkflow-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
"@mui/material": "^5.15.18",
"@prefresh/vite": "^2.4.5",
"@react-icons/all-files": "^4.1.0",
"@rjsf/core": "5.18.3",
"@rjsf/mui": "5.18.3",
"@rjsf/utils": "5.18.3",
"@rjsf/validator-ajv8": "5.0.0",
"@rjsf/core": "^5.18.4",
"@rjsf/mui": "^5.18.4",
"@rjsf/utils": "^5.18.4",
"@rjsf/validator-ajv8": "github:sartography/rjsf-validator-ajv8-test#peformance-improvement-w-build",
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The repository sartography/rjsf-validator-ajv8-test does not exist, and no relevant repositories were found under the sartography organization or through a broader search. Please verify the repository name or consider using a different source for the @rjsf/validator-ajv8 dependency.

Analysis chain

Using a custom GitHub repository version for @rjsf/validator-ajv8. Ensure to monitor the stability and updates of this repository.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the last commit date of the custom repository to ensure it's actively maintained.

# Test: Fetch the latest commit date from the repository. Expect: Recent commit date.
gh repo view sartography/rjsf-validator-ajv8-test --json updatedAt

Length of output: 178

Script:

#!/bin/bash
# Description: List all repositories under the `sartography` organization to verify the correct repository name.

# Test: Fetch the list of repositories from the `sartography` organization. Expect: List of repositories.
gh repo list sartography --json name

Length of output: 933

Script:

#!/bin/bash
# Description: Search for repositories related to `rjsf-validator-ajv8` across all organizations.

# Test: Fetch the list of repositories matching `rjsf-validator-ajv8` across all organizations. Expect: List of repositories.
gh search repos "rjsf-validator-ajv8" --json name,owner

Length of output: 214

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was private, dogg. now public.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnettk, thanks for the update! Now that the repository sartography/rjsf-validator-ajv8-test is public, the dependency should be accessible as specified. If there's anything else you need to ensure everything is set up correctly, feel free to let me know!

"@tanstack/react-query": "^5.40.0",
"@tanstack/react-query-devtools": "^5.40.0",
"@testing-library/jest-dom": "^6.4.2",
Expand Down
Loading