Rjsf typing is slow #1663
Rjsf typing is slow #1663
Conversation
WalkthroughWalkthroughThe recent updates to the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant Script as task_data_to_python_variables.py
participant JSONFile as JSON File
participant PythonFile as Python File
User->>Script: Execute script with JSON file path
Script->>JSONFile: Read task data
JSONFile-->>Script: Return task data
Script->>PythonFile: Write Python variables
PythonFile-->>User: Output Python file with variables
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
spiffworkflow-frontend/package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (2)
- spiffworkflow-backend/bin/task_data_to_python_variables.py (1 hunks)
- spiffworkflow-frontend/package.json (1 hunks)
Additional context used
Biome
Additional comments not posted (3)
spiffworkflow-backend/bin/task_data_to_python_variables.py (2)
7-20: Themain()function implementation looks good and adheres to the expected functionality.
25-26: Correct use of the Python idiom for script execution.spiffworkflow-frontend/package.json (1)
21-23: Updated@rjsf/*dependencies to5.18.4to address performance issues.
| "@rjsf/core": "^5.18.4", | ||
| "@rjsf/mui": "^5.18.4", | ||
| "@rjsf/utils": "^5.18.4", | ||
| "@rjsf/validator-ajv8": "github:sartography/rjsf-validator-ajv8-test#peformance-improvement-w-build", |
There was a problem hiding this comment.
Tip
Codebase Verification
The repository sartography/rjsf-validator-ajv8-test does not exist, and no relevant repositories were found under the sartography organization or through a broader search. Please verify the repository name or consider using a different source for the @rjsf/validator-ajv8 dependency.
Analysis chain
Using a custom GitHub repository version for @rjsf/validator-ajv8. Ensure to monitor the stability and updates of this repository.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the last commit date of the custom repository to ensure it's actively maintained.
# Test: Fetch the latest commit date from the repository. Expect: Recent commit date.
gh repo view sartography/rjsf-validator-ajv8-test --json updatedAt
Length of output: 178
Script:
#!/bin/bash
# Description: List all repositories under the `sartography` organization to verify the correct repository name.
# Test: Fetch the list of repositories from the `sartography` organization. Expect: List of repositories.
gh repo list sartography --json name
Length of output: 933
Script:
#!/bin/bash
# Description: Search for repositories related to `rjsf-validator-ajv8` across all organizations.
# Test: Fetch the list of repositories matching `rjsf-validator-ajv8` across all organizations. Expect: List of repositories.
gh search repos "rjsf-validator-ajv8" --json name,owner
Length of output: 214
There was a problem hiding this comment.
it was private, dogg. now public.
There was a problem hiding this comment.
@burnettk, thanks for the update! Now that the repository sartography/rjsf-validator-ajv8-test is public, the dependency should be accessible as specified. If there's anything else you need to ensure everything is set up correctly, feel free to let me know!
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- spiffworkflow-backend/bin/task_data_to_python_variables.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- spiffworkflow-backend/bin/task_data_to_python_variables.py
Supports #1565
Uses branch from PR rjsf-team/react-jsonschema-form#4204 to help with performance improvements in rjsf.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
@rjsf/core,@rjsf/mui, and@rjsf/utilsto5.18.4.@rjsf/validator-ajv8from a specific GitHub repository.