Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS targets #102

Closed
wants to merge 1 commit into from
Closed

Add iOS targets #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gradle/build-logic/convention/src/main/kotlin/KotlinMultiplatformConventionPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ class KotlinMultiplatformConventionPlugin : Plugin<Project> {
extensions.configure<KotlinMultiplatformExtension> {
applyDefaultHierarchyTemplate()
jvm("desktop")
iosArm64()
iosX64()
iosSimulatorArm64()
Comment on lines +26 to +28
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with publishing KMP libraries for iOS. I think we may need the equivalent to publishLibraryVariants but for iOS?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I'm not sure either. Let's try merging this and seeing if a SNAPSHOT version gets published correctly for iOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on the failures on this PR? The error mentions a missing android target, but I did not modify that 🤔

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm just seeing this. Let me try building the project on my machine.

if (pluginManager.hasPlugin("com.android.library")) {
androidTarget {
publishLibraryVariants("release")
Expand Down
Loading