Add iOS targets #102
Add iOS targets #102
Conversation
Add support for iOS targets
| iosArm64() | ||
| iosX64() | ||
| iosSimulatorArm64() |
There was a problem hiding this comment.
Not familiar with publishing KMP libraries for iOS. I think we may need the equivalent to publishLibraryVariants but for iOS?
There was a problem hiding this comment.
Yea I'm not sure either. Let's try merging this and seeing if a SNAPSHOT version gets published correctly for iOS.
There was a problem hiding this comment.
Any ideas on the failures on this PR? The error mentions a missing android target, but I did not modify that 🤔
There was a problem hiding this comment.
Sorry I'm just seeing this. Let me try building the project on my machine.
| iosArm64() | ||
| iosX64() | ||
| iosSimulatorArm64() |
There was a problem hiding this comment.
Yea I'm not sure either. Let's try merging this and seeing if a SNAPSHOT version gets published correctly for iOS.
|
Hi any update here ? |
|
Closing this PR as I ended up merging the commit manually. Git wasn't letting me force-push to your branch @Vichy97. |
|
@wang222222222 @Vichy97 iOS targets are now available with |
|
@saket https://mvnrepository.com/artifact/me.saket.telephoto/zoomable I don't the snapshot version on Maven. |
|
Snapshot builds are available in the snapshot repository: maven("https://oss.sonatype.org/content/repositories/snapshots/") |
|
Hmm it doesn't appear to have ios artifacts. was able to use it in Android using the snapshot though. |
|
I think you maybe need more changes than just adding the iOS target that I had in my pr, but I'm honestly not sure what else you need for the iOS targets to be uploaded. |
|
Interesting. It looks like telephoto will need to enable this option: https://kotlinlang.org/docs/multiplatform-publish-lib.html#host-requirements |
|
Ah that makes sense. I'm happy to try the next snapshot if you add that change! I could also try to make a PR soon |
|
@Vichy97 can you give it another try? https://oss.sonatype.org/content/repositories/snapshots/me/saket/telephoto/zoomable-iosarm64/0.15.0-SNAPSHOT/ cc @vanniktech |
|
Yup works for me on iOS. |
|
Weirdly when I change: -telephoto = "me.saket.telephoto:zoomable:0.15.0-SNAPSHOT"
+telephoto = "me.saket.telephoto:zoomable-image-coil3:0.15.0-SNAPSHOT"Android Studio sync throws up:
So the zoomable module works on iOS, the zoomable-image-coil3, does build but Gradle Sync is broken. Is the iosArm64 variant missing there? |
|
Yep, |
|
@saket everything seems to be working now. Thanks for doing that! |
|
Is |
|
Yea this should be doable now. Since Coil 3.x restricts the maximum size of bitmaps, large images will not cause a crash even if they can't be sub-sampled. Time to start moving |
|
I've ended up using the |
Add support for iOS targets