Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Apr 28, 2024
Uxio0
commented
- Closes Check if ETHEREUM_4337_BUNDLER_URL uses the same chainId as ETHEREUM_NODE_URL #1987
Uxio0
force-pushed
the
check-bundler-same-chain-id
branch
from
e06fe1e to
c5c256b
Compare
moisses89
reviewed
Apr 29, 2024
| """ | ||
| if settings.ETHEREUM_4337_BUNDLER_URL: | ||
| return BundlerClient(settings.ETHEREUM_4337_BUNDLER_URL) | ||
| logger.warning("ETHEREUM_4337_BUNDLER_URL not set, cannot configure bundler client") |
There was a problem hiding this comment.
I suggest to remove the redundant warning after call this cached function here https://github.com/safe-global/safe-transaction-service/pull/2013/files#diff-2061896cceba9e91196c8a52412e1843ee140f0994f24987f02734187d40e7f9R48
There was a problem hiding this comment.
One warning is for the bundler client, other is for initializing the AccountAbstractionService, I don't think they are redundant
| bundler_client = get_bundler_client() | ||
| if bundler_client: | ||
| bundler_chain_id = bundler_client.get_chain_id() | ||
| if bundler_chain_id == chain_id: |
There was a problem hiding this comment.
Why not uses the database chain.chain_id field instead the RPC value?
For me is clearer to compare with database than a field that was previously checked with database.
I mean, database is the source of truth.
Uxio0
force-pushed
the
check-bundler-same-chain-id
branch
from
c5c256b to
56cb2ad
Compare
Uxio0
force-pushed
the
check-bundler-same-chain-id
branch
from
56cb2ad to
90730cf
Compare
moisses89
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.