Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if ETHEREUM_4337_BUNDLER_URL uses the same chainId as ETHEREUM_NODE_URL #1987

Closed
luarx opened this issue Apr 11, 2024 · 3 comments · Fixed by #2013
Closed

Check if ETHEREUM_4337_BUNDLER_URL uses the same chainId as ETHEREUM_NODE_URL #1987

luarx opened this issue Apr 11, 2024 · 3 comments · Fixed by #2013
Assignees
@Uxio0
Labels
enhancement New feature or request

Comments

@luarx
Copy link
Contributor

luarx commented Apr 11, 2024

What is needed?

It would be great to check if ETHEREUM_4337_BUNDLER_URL uses the same chainId as ETHEREUM_NODE_URL so that we can detect mistakes of using different chain_ids in the same service

In case that chainId is different, an option could be:

  • Show an error log and do not start
@luarx luarx added the enhancement New feature or request label Apr 11, 2024
@Uxio0 Uxio0 self-assigned this Apr 11, 2024
@Uxio0
Copy link
Member

Uxio0 commented Apr 12, 2024

Depends on safe-global/safe-eth-py#899

@luarx
Copy link
Contributor Author

luarx commented Apr 26, 2024

safe-global/safe-eth-py#899 has been completed 🙌
So this can be scheduled to be implemented 🚀

Uxio0 added a commit that referenced this issue Apr 28, 2024
@Uxio0
Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId
e06fe1e 
- Closes #1987
@Uxio0 Uxio0 mentioned this issue Apr 28, 2024
Merged
@Uxio0
Copy link
Member

Uxio0 commented Apr 28, 2024 •
edited
Loading

@luarx PR is ready for review #2013

Uxio0 added a commit that referenced this issue Apr 28, 2024
@Uxio0
Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId
c5c256b 
- Closes #1987
Uxio0 added a commit that referenced this issue Apr 29, 2024
@Uxio0
Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId
56cb2ad 
- Closes #1987
Uxio0 added a commit that referenced this issue Apr 29, 2024
@Uxio0
Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId
90730cf 
- Closes #1987
Uxio0 added a commit that referenced this issue Apr 29, 2024
@Uxio0
Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId
eaf3099 
- Closes #1987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if ETHEREUM_4337_BUNDLER_URL uses the correct chainId safe-global/safe-transaction-service
2 participants
@Uxio0 @luarx