Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tracking when candidates for PR assignment are filtered out #1895

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Better tracking when candidates for PR assignment are filtered out #1895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0060d11
Remove redundant utility fn
apiraino Jan 29, 2025
0c0d658
Increase logging when no candidates for PR assignment are found
apiraino Jan 29, 2025
82c549a
Split and track reasons when candidates for PR assignment are filtere…
apiraino Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/handlers/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ Use `r?` to explicitly pick a reviewer";
const RETURNING_USER_WELCOME_MESSAGE_NO_REVIEWER: &str =
"@{author}: no appropriate reviewer found, use `r?` to override";

const ON_VACATION_WARNING: &str = "{username} is on vacation. Please do not assign them to PRs.";
const ON_VACATION_WARNING: &str = "{username} is on vacation.

Please choose another assignee.";

const NON_DEFAULT_BRANCH: &str =
"Pull requests are usually filed against the {default} branch for this repo, \
Expand Down Expand Up @@ -508,7 +510,10 @@ pub(super) async fn handle_command(
{
// This is a comment, so there must already be a reviewer assigned. No need to assign anyone else.
issue
.post_comment(&ctx.github, &on_vacation_msg(&username))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the deletion of on_vacation_msg is in 82c549a (sorry)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the functions better than the consts, because with the function you cannot forget to pass the required placeholders, with the static string you can easily just use it without replacing the placeholder.

.post_comment(
&ctx.github,
&ON_VACATION_WARNING.replace("{username}", &username),
)
.await?;
return Ok(());
}
Expand Down