Better tracking when candidates for PR assignment are filtered out #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
commented
Jan 29, 2025
| @@ -508,7 +510,10 @@ pub(super) async fn handle_command( | |||
| { | |||
| // This is a comment, so there must already be a reviewer assigned. No need to assign anyone else. | |||
| issue | |||
| .post_comment(&ctx.github, &on_vacation_msg(&username)) | |||
There was a problem hiding this comment.
the deletion of on_vacation_msg is in 82c549a (sorry)
There was a problem hiding this comment.
I find the functions better than the consts, because with the function you cannot forget to pass the required placeholders, with the static string you can easily just use it without replacing the placeholder.
Kobzol
reviewed
Jan 30, 2025
| // return Err(FindReviewerError::AllReviewersFiltered { | ||
| // initial: names.to_vec(), | ||
| // filtered: names.to_vec(), | ||
| // }); | ||
| } | ||
|
|
||
| log::info!("Filtered list of candidates: {:?}", filtered_candidates); | ||
| log::info!( |
There was a problem hiding this comment.
We should really migrate to tracing and use spans to get have proper log context :)
| @@ -508,7 +510,10 @@ pub(super) async fn handle_command( | |||
| { | |||
| // This is a comment, so there must already be a reviewer assigned. No need to assign anyone else. | |||
| issue | |||
| .post_comment(&ctx.github, &on_vacation_msg(&username)) | |||
There was a problem hiding this comment.
I find the functions better than the consts, because with the function you cannot forget to pass the required placeholders, with the static string you can easily just use it without replacing the placeholder.
Kobzol
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Besides these changes, nothing in the PR assignment changes. Overall, this should help us getting more insights from the logs. I've tried splitting the changes in commits to make the review easier.
Thanks!
r? @Kobzol or @jackh726