Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix changelog generation #1817

Merged
merged 2 commits into from
Aug 1, 2024
Merged

chore: fix changelog generation #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771e445
chore: fix workflows to use the appropraite commit for checkout
saikumarrs Aug 1, 2024
d405d65
chore: fix version target to push changes at the end
saikumarrs Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/deploy-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.sha }}

- name: Get new version number
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/deploy-sanity-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ github.sha }}

- name: Configure deployment options
id: deployment-options
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ on:
type: string
required: false
default: ''
use_pr_head_sha:
type: string
default: 'false'
secrets:
AWS_ACCOUNT_ID:
required: true
Expand Down Expand Up @@ -63,8 +66,21 @@ jobs:
role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/${{ secrets.AWS_S3_SYNC_ROLE }}
aws-region: us-east-1

- name: Determine checkout SHA
id: getSHA
run: |
if ${{ inputs.use_pr_head_sha }} == 'true'; then
sha=$(echo ${{ github.event.pull_request.head.sha }})
else
sha=$(echo ${{ github.sha }})
fi
echo "Checkout SHA: $sha"
echo "SHA=$sha" >> $GITHUB_OUTPUT

- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ steps.getSHA.outputs.SHA }}

- name: Get new version number
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish-new-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.sha }}

# In order to make a commit, we need to initialize a user.
# You may choose to write something less generic here if you want, it doesn't matter functionality wise.
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/security-code-quality-and-bundle-size-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup Node
uses: actions/setup-node@v4
Expand Down Expand Up @@ -43,6 +45,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup Node
uses: actions/setup-node@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit-tests-and-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- name: Setup Node
uses: actions/setup-node@v4
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js-common/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js-cookies/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js-integrations/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js-plugins/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js-service-worker/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-js/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/analytics-v1.1/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/loading-scripts/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
},
"github": {
Expand Down
5 changes: 3 additions & 2 deletions packages/sanity-suite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"executor": "@jscutlery/semver:version",
"options": {
"baseBranch": "main",
"preset": "conventional",
"preset": "conventionalcommits",
"tagPrefix": "{projectName}@",
"trackDeps": true
"trackDeps": true,
"push": true
}
}
}
Expand Down