chore: fix changelog generation #1817
Conversation
WalkthroughWalkthroughThe recent changes to the GitHub Actions workflows primarily focus on enhancing the checkout process by ensuring that the exact commit or pull request head SHA is used during deployments and testing. This modification increases the reliability and traceability of workflows by aligning the code being built or tested with the specific commit that triggered the action. Additionally, a new input parameter introduces flexibility for utilizing the pull request's latest changes, further improving deployment accuracy. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (9)
packages/analytics-js-common/project.jsonis excluded by!**/*.jsonpackages/analytics-js-cookies/project.jsonis excluded by!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by!**/*.jsonpackages/analytics-js-service-worker/project.jsonis excluded by!**/*.jsonpackages/analytics-js/project.jsonis excluded by!**/*.jsonpackages/analytics-v1.1/project.jsonis excluded by!**/*.jsonpackages/loading-scripts/project.jsonis excluded by!**/*.jsonpackages/sanity-suite/project.jsonis excluded by!**/*.json
Files selected for processing (6)
- .github/workflows/deploy-npm.yml (1 hunks)
- .github/workflows/deploy-sanity-suite.yml (1 hunks)
- .github/workflows/deploy.yml (2 hunks)
- .github/workflows/publish-new-release.yml (1 hunks)
- .github/workflows/security-code-quality-and-bundle-size-checks.yml (2 hunks)
- .github/workflows/unit-tests-and-lint.yml (1 hunks)
Additional comments not posted (9)
.github/workflows/unit-tests-and-lint.yml (1)
24-24: LGTM! Therefparameter enhances the checkout step.The addition of the
refparameter ensures that the workflow checks out the specific commit associated with the pull request, improving reliability and traceability..github/workflows/security-code-quality-and-bundle-size-checks.yml (2)
18-19: LGTM! Therefparameter enhances the checkout step.The addition of the
refparameter ensures that the workflow checks out the specific commit associated with the pull request, improving reliability and traceability.
48-48: LGTM! Therefparameter enhances the checkout step.The addition of the
refparameter ensures that the workflow checks out the specific commit associated with the pull request, improving reliability and traceability..github/workflows/publish-new-release.yml (1)
43-43: LGTM! Therefparameter enhances the checkout step.The addition of the
refparameter ensures that the workflow checks out the specific commit associated with the pull request, improving reliability and traceability..github/workflows/deploy-sanity-suite.yml (1)
62-63: LGTM! Ensuring the exact commit SHA is checked out.The addition of the
withclause specifyingref: ${{ github.sha }}ensures that the workflow checks out the exact commit that triggered the workflow. This enhances the consistency and reliability of the deployment process..github/workflows/deploy-npm.yml (1)
39-39: LGTM! Ensuring the exact commit SHA is checked out.The addition of the
refparameter specifyingref: ${{ github.sha }}ensures that the workflow checks out the exact commit that triggered the workflow. This enhances the reliability of the build process by ensuring that the code being built corresponds precisely to the commit in question..github/workflows/deploy.yml (3)
27-29: LGTM! Introducing theuse_pr_head_shainput parameter.The new input parameter
use_pr_head_shaallows users to specify whether to use the SHA of the pull request's head instead of the default commit SHA. This enhances the flexibility of the workflow.
69-79: LGTM! Determining the checkout SHA based on the new input parameter.The new step determines which SHA to use based on the value of
use_pr_head_sha. If the input is 'true', the SHA from the pull request's head is used; otherwise, the default commit SHA is retained. This step ensures that the correct SHA is used for the checkout process.
82-83: LGTM! Using the determined SHA for the checkout step.The checkout step now references the determined SHA. This ensures that the workflow checks out the correct commit based on the logic defined in the previous step.
size-limit report 📦
|
PR Description
Fixed the
versiontarget options of all the packages to push updates at the end to help in generating correct changelogs.Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2227/fix-changelog-generation-during-release
Cross Browser Tests
N/A
Sanity Suite
Security
Summary by CodeRabbit