Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary window globals declarations #1687

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: remove unnecessary window globals declarations #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e84496
fix: remove unnecessary window globals declarations
saikumarrs Apr 10, 2024
e96405c
fix: further clean up declaration files
saikumarrs Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/analytics-js/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { RudderAnalytics } from './app/RudderAnalytics';
import type { RudderAnalyticsPreloader } from './components/preloadBuffer/types';
import type { IRudderStackGlobals } from './app/IRudderStackGlobals';

export {
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
type AnonymousIdOptions,
Expand All @@ -21,7 +20,6 @@ export { type LogLevel } from '@rudderstack/analytics-js-common/types/Logger';
export { type PluginName } from '@rudderstack/analytics-js-common/types/PluginsManager';
export { type IdentifyTraits } from '@rudderstack/analytics-js-common/types/traits';
export { RudderAnalytics } from './app/RudderAnalytics';
export { type IRudderStackGlobals } from './app/IRudderStackGlobals';
export {
type RudderAnalyticsPreloader,
type PreloadedEventCall,
Expand All @@ -30,8 +28,5 @@ export {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
}
}
2 changes: 0 additions & 2 deletions packages/analytics-js/src/types/rudderanalytics.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
}
}
2 changes: 0 additions & 2 deletions packages/loading-scripts/src/types/rudderanalytics.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {
IRudderStackGlobals,
RudderAnalytics,
PreloadedEventCall,
RudderAnalyticsPreloader,
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -8,7 +7,6 @@ import type {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
Expand Down
5 changes: 0 additions & 5 deletions packages/sanity-suite/src/types/rudderanalytics.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {
IRudderStackGlobals,
RudderAnalytics,
PreloadedEventCall,
RudderAnalyticsPreloader,
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -8,9 +7,5 @@ import type {
declare global {
interface Window {
rudderanalytics: RudderAnalytics | RudderAnalyticsPreloader | undefined;
RudderStackGlobals: IRudderStackGlobals;
rudderAnalyticsMount: () => void;
rudderAnalyticsBuildType: 'legacy' | 'modern';
RudderSnippetVersion?: string;
}
}