-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary window globals declarations #1687
Conversation
WalkthroughThe recent updates involve streamlining the global namespace by removing specific types and declarations related to Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review as they are similar to previous changes (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1687 +/- ##
========================================
Coverage 53.93% 53.93%
========================================
Files 461 461
Lines 15616 15616
Branches 3109 3089 -20
========================================
Hits 8422 8422
- Misses 5840 5907 +67
+ Partials 1354 1287 -67 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Quality Gate passedIssues Measures |
PR Description
Excluded unwanted window globals declarations and exports from the package.
Please take a look at the linked Linear ticket for more details.
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-1588/fix-exported-window-globals-type-js-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security