[AMCL] 9x initialisation (and reset) speed increase #4941
+22
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
On VERY big maps, the method
map_update_cspace
of AMCL takes ages. Which makes AMCL long to start, or reset (when for instance changing a dynamic parameter needingreinit_laser = true
)3 tricks by order of impact:
std::queue
instead ofstd::priority_queue
. But this is why this is a draft, I cannot understand whystd::priority_queue
was needed in the first place (and which criteria it used for ordering), so I am not sure.CellData
copy withemplace
instead of push.On a big map, AMCL activation times drops from 22s to 2.4s on my machine.
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers: