Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized element used in mppi trajectory test #4935

Merged

Conversation

mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4934
Primary OS tested on Ubuntu
Robotic platform tested on
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Fix bug as described in the issue

Description of documentation updates required from your changes

Description of how this change was tested

Unit test run around 10000 rounds, no error occured


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@mini-1235 mini-1235 changed the title Fix uninitialized column used in mppi trajectory test Fix uninitialized element used in mppi trajectory test Feb 20, 2025
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few PRs from you over the last couple of weeks. First off, thanks! I’ll be getting to them all this week. I was out of town for a wedding the last 2 weeks and flying back home as we speak. Thanks for your patience.

@SteveMacenski SteveMacenski merged commit 14a0031 into ros-navigation:main Mar 1, 2025
11 checks passed
@mini-1235
Copy link
Contributor Author

I see a few PRs from you over the last couple of weeks. First off, thanks! I’ll be getting to them all this week. I was out of town for a wedding the last 2 weeks and flying back home as we speak. Thanks for your patience.

No worries at all! I really appreciate you taking the time to review them

@mini-1235 mini-1235 deleted the patch-uninitialized-var branch March 1, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants