Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tf for costmap tests #4930

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4929
Primary OS tested on Ubuntu
Robotic platform tested on
Does this PR contain AI generated software?

Description of contribution in a few bullet points

  • Fixes the issue, only publish static transform for tests that need it

Description of documentation updates required from your changes

None

Description of how this change was tested

Tested the buggy tests independently for 1000 rounds, and run colcon test for 10 rounds


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mini-1235
Copy link
Contributor Author

mini-1235 commented Feb 19, 2025

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 4 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 9677e68 into ros-navigation:main Mar 4, 2025
11 checks passed
@mini-1235 mini-1235 deleted the patch-duplicate-tf branch March 5, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants