Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Name on Quick Filters. #997

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

cbordeman
Copy link
Contributor

@rmcrackan
Copy link
Owner

I'm back in town and slowly working through my mountain of emails.

This PR looks good. I'm a little hesitant about the migration code in the QuickFilters static ctor. It's just that if anything goes wrong in a static ctor, we can get in a weird state. Historically I've handled migrations in a central place. Eg:

Migrations.migrate_to_v6_6_9(config);

If it's not too much trouble, could you do this with your migration? The next version can be 11.4.2 or 11.5 -- your choice.

RE version: a lot of users had issues last year when I updated .net. Since then, I rolled back and have been slowly adding to the code base and I think I fixed the issue they were having. So fairly soon, we can create an actual new release version. I see I have some other stuff from you and I'll take a look at that before creating a new release. Before releasing, I'd also like to see where that conversation goes with adding a player.

@cbordeman
Copy link
Contributor Author

Sure, I usually use a more formal upgrade process, like you do. I will migrate to that.

@cbordeman
Copy link
Contributor Author

I'll use 11.5, seems like a good time.

@cbordeman
Copy link
Contributor Author

Moved the migration. If I understood the migration strategy a little better, I might have written the code differently, though. It seems like if it fails, the app fails a migration method; is that what we want to happen? Currently, if it fails, I'm creating a new, empty QuickFilters.cs...

@rmcrackan rmcrackan merged commit 8a87462 into rmcrackan:master Oct 15, 2024
8 checks passed
@rmcrackan
Copy link
Owner

I merged and tested it out in Classic. Pretty slick!

@rmcrackan
Copy link
Owner

Included in latest pre-release -- https://github.com/rmcrackan/Libation/releases/tag/v11.5.0

Let me know when you have a better idea about the player. That would be one with a big wow-factor and I'd wait for it to be finalized before making a new public release.

@cbordeman
Copy link
Contributor Author

Occurs to me I didn't update the version # on the Winforms side. Can you do that?

@rmcrackan
Copy link
Owner

What version on the winforms side?

@cbordeman
Copy link
Contributor Author

Is there not a version in there somewhere? Like in the Avalonia project file or a Properties.cs? You're the expert.

@rmcrackan
Copy link
Owner

The only version should come from that shared spot in appscaffolding

<Version>11.5.0.1</Version>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants