Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable friendly naming quick filters (I will PR) #995

Open
cbordeman opened this issue Oct 10, 2024 · 12 comments
Open

Enable friendly naming quick filters (I will PR) #995

cbordeman opened this issue Oct 10, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@cbordeman
Copy link
Contributor

Would like to have a Name column on the edit filters windows. If present, the Name would display on the menu.

I'll PR this.

@cbordeman cbordeman added the enhancement New feature or request label Oct 10, 2024
@rmcrackan
Copy link
Owner

Hey, what's the matter? My hack ain't good enough for you?

Screenshot 2024-10-10 07 34 05

😄 Thanks for the new feature.

A word of warning: I keep classic (winforms) and chardonnay (avalonia/xaml) as close to feature parity as possible. Any UI changes will need to be made to both. (Obviously unless it's framework-specific like the PR you did for the xaml scroll bars.)

@cbordeman
Copy link
Contributor Author

cbordeman commented Oct 10, 2024

I actually didn't notice you could do the hack, but I think making it formal has some value for the same reason.

I'm going to go ahead and have a go at a separate field, though my WinForms experience is very limited. IMO the chardonnay (Avalonia) is so much better, is there a reason it is still around? Pardon my ignorance.

@cbordeman
Copy link
Contributor Author

Also, I realize that while loading the filters, I'll need to handle the missing name field gracefully so as to not nuke existing data.

@rmcrackan
Copy link
Owner

is there a reason it is still around?

Fair question and one I've considered. Despite the legion reasons not use winforms:

  • Years before Libation was Libation, this was just an app I made for myself in winforms. (Winforms was the only version until another dev'er did the full Avalonia port a few years ago.) It's simply what I knew better so I went with it.
  • Every time I try to do more than trivial things in xaml I end up tearing out my hair. Of which I have little to spare.
  • It's absolutely rock solid and supported officially by MS. Every so often bugs come up in Avalonia. I don't know if I've ever found a proper bug in winforms since I started using it over 20 years ago.
  • It's time-tested and filled with mature things. It's had out of the box screen reader support since forever. I don't have accessibility needs but I have close family who do so I'm especially sensitive to such things.

@CharlieRussel
Copy link

As a devoted user of Libation in its Classic (winform) implementation, I'd be really unhappy if it went away. It has the one thing going for it that beats everything, it JFW.

@rmcrackan
Copy link
Owner

JFW

lol. No worries friend -- classic isn't going anywhere. Classic and Chardonnay are here to stay. One day I'll remember to write up an explanation in the faq. One day...

@cbordeman
Copy link
Contributor Author

@CharlieRussel What doesn't just work in the chardonnay?

@cbordeman
Copy link
Contributor Author

@rmcrackan That's a very good explanation, thanks. WPF is actually rock solid, too, since it's not been receiving feature updates for several years now. But Avalonia so new, it certainly still has holes, and there's few third party libs. I'm brand new to it, and the reimagined styling system is weird!

@CharlieRussel
Copy link

@cbordeman -- Not being the developer here, I'm not sure what does/doesn't work. But I know from following the bugs/remediations here that @rmcrackan and others have sometimes had to jump through some hoops to get things working. As of now, so far as I know, the functionality is equivalent. But I'm old school and quite happy with the L&F of classic.

@cbordeman
Copy link
Contributor Author

cbordeman commented Oct 10, 2024

Gotcha. I'm here to try to made this app useful to the blind and nearly blind, since I have blind relatives. I am not seeing any big bugs, really, just hoping to fix any big showstoppers. Thanks for your answer.

@cbordeman
Copy link
Contributor Author

PR #997 created.

@rmcrackan
Copy link
Owner

Thanks. I’m heading out of town for a few days and will look at this early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants