Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): namespace metrics for unaligned join logstore #20375

Open
wants to merge 3 commits into
base: 01-06-feat_stream_add_synced_logstores
Choose a base branch
from

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 4, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?'

Separate metrics from connector metrics

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor Author

kwannoel commented Feb 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kwannoel kwannoel changed the title refactor constructor feat(stream): add dedicated metrics for unaligned join logstore Feb 4, 2025
@kwannoel kwannoel force-pushed the kwannoel/metrics-2 branch 7 times, most recently from dfc81a7 to aa8bfa2 Compare February 6, 2025 09:05
@kwannoel kwannoel requested review from wenym1 and chenzl25 February 6, 2025 10:40
@kwannoel kwannoel marked this pull request as ready for review February 6, 2025 10:40
@kwannoel kwannoel changed the title feat(stream): add dedicated metrics for unaligned join logstore feat(stream): namespace metrics for unaligned join logstore Feb 6, 2025
@kwannoel kwannoel force-pushed the 01-06-feat_stream_add_synced_logstores branch from 1c4dd36 to 9f70496 Compare February 6, 2025 12:20
@kwannoel kwannoel requested a review from a team as a code owner February 6, 2025 12:20
@kwannoel kwannoel requested review from stdrc and removed request for a team February 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant