Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StoreIdViewMixin and add samesite to storeid cookie #1012

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jochenklar
Copy link
Member

No description provided.

@jochenklar jochenklar added this to the RDMO 2.2.0 milestone Jun 3, 2024
@jochenklar jochenklar requested a review from MyPyDavid June 3, 2024 15:51
@jochenklar jochenklar self-assigned this Jun 3, 2024
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, another Mixin!

tested it locally, seems fine for /projects and /management, the cookie is set.
Thanks! 🙏

@jochenklar jochenklar merged commit 23d7dcd into dev-2.2.0 Jun 4, 2024
17 checks passed
@jochenklar jochenklar deleted the fix_storeid branch June 4, 2024 07:56
@MyPyDavid MyPyDavid linked an issue Jun 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our cookie 'storeid' needs a value for the SameSite attribute
2 participants