Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our cookie 'storeid' needs a value for the SameSite attribute #904

Closed
MyPyDavid opened this issue Jan 18, 2024 · 0 comments · Fixed by #1012
Closed

Our cookie 'storeid' needs a value for the SameSite attribute #904

MyPyDavid opened this issue Jan 18, 2024 · 0 comments · Fixed by #1012

Comments

@MyPyDavid
Copy link
Member

Description / Beschreibung

Currently, in my local debug environment I get a warning in the Mozilla Development Browser about the SameSite attribute:

Cookie “storeid” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Before I got the CSRF token error in Chrome and thought it was related to the cookie warning, see js-cookie/js-cookie#846 for example.

Expected behaviour / Erwartetes Verhalten

  • our cookie storeid should not get any warnings and get the appropriate attributes

Context / Kontext

Local Debug, 2.1.2

References / Verweise

@MyPyDavid MyPyDavid changed the title Our cookie 'storeid' should get a value for the SameSite attribute Our cookie 'storeid' needs a value for the SameSite attribute Jan 18, 2024
@MyPyDavid MyPyDavid added this to the 2.2.0 milestone Jan 18, 2024
@jochenklar jochenklar self-assigned this Jan 19, 2024
@MyPyDavid MyPyDavid linked a pull request Jun 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants