Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting non-energetic and delayed emissions in co2 chart #3174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notes in this query should be updated, they now still refer to the non-energetic emissions as well.

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Includes non_energetic emissions from the fertilizer industry (SMR),
# non-energetic hydrogen final demand, non-energetic ammonia final demand and
# 'delayed' emissions in molecules_other_utilisation_co2 node
# More non_energetic emissions may be added in the future

- unit = mt
- query =
DIVIDE(
MV(
molecules_other_utilisation_delayed_emitted_co2,
demand),
BILLIONS
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments:

  • The notes refer to primary_co2_of_non_energetic_and_delayed_emissions, which is now split into separate queries for non energetic and delayed emissions. Therefore, the notes should refer to primary_co2_of_non_energetic.
  • 3rd sentence: change beginning of the sentence to 'this node's primary CO2 emissions will at...'

Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Within the co2_emissions_refinery_products the node industry_final_demand_methanol_non_energetic is queried.
# This node should actually be in query : primary_co2_of_non_energetic_and_delayed_emissions.
# the primary CO2 emissions will at the moment always be 0 since its free_co2_factor is 1 (no C atoms will be released in non-energetic use of methanol).
# For now, there is no situation where we have nodes with group co2_emissions_refinery_products with non-energetic use where primary CO2 emissions should be taken into account.

- unit = mt
- query =
DIVIDE(
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments regarding query notes:

  • the part referring to delayed emissions should be removed
  • change the last sentence to refer to the specific group and sector, such as 'non-energetic final demand of group co2_emissions_refinery_products in the industry sector is not (yet) included in this query, which currently only consists of non-energetic methanol final demand. Since its free_co2_factor is 1.0, the method of querying this node currenlty doesn't affect the results'.
  • Make sure to break a sentence to the next line when it gets too long, currently the case for the last sentence

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# non-energetic hydrogen final demand, non-energetic ammonia final demand and
# 'delayed' emissions in molecules_other_utilisation_co2 node
# More non_energetic emissions may be added in the future
# non-energetic methanol is not (yet) included in this query. At the moment this is queried in the query primary_co2_of_industry, since the free_co2_factor of the node industry_final_demand_methanol_non_energetic is 1.0.

- unit = mt
- query =
Expand All @@ -14,9 +15,6 @@
SECTOR(industry)),
USE(non_energetic)),
primary_co2_emission),
MV(
molecules_other_utilisation_delayed_emitted_co2,
demand),
NEG(
SUM(
MV(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
Q(primary_co2_of_energy),
Q(primary_co2_of_households),
Q(primary_co2_of_industry),
Q(primary_co2_of_non_energetic_and_delayed_emissions),
Q(primary_co2_of_non_energetic),
Q(primary_co2_of_delayed_emissions),
Q(primary_co2_of_other),
Q(primary_co2_of_transport)
)
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this added sentence correctly, can you explain this?

Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Methanol is treated as a refinery product, since it can be produced synthetically
# The primary emissions of the hydrogen and electricity required to produce the synthetic
# methanol, are allocated to the relevant synthetic production nodes.
# In the future we might want to attribute these emissions to the relevant final demand groups, the free_co2_factor should be set to 0.0 at that time.

- use = non_energetic
- groups = [final_demand_group, non_energetic_use, co2_emissions_refinery_products]
Expand Down