Splitting non-energetic and delayed emissions in co2 chart #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
kndehaan
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Looking good! Notes:
- Some comments on query notes, see specific comments per file
myc_primary_co2_in_non_energetic_and_delayed_emissionsstill refers toprimary_co2_of_non_energetic_and_delayed_emissions. This should be corrected, for instance by creating a new query that sumsprimary_co2_of_delayed_emissionsandprimary_co2_of_non_energetic
There was a problem hiding this comment.
The notes in this query should be updated, they now still refer to the non-energetic emissions as well.
There was a problem hiding this comment.
Few comments:
- The notes refer to
primary_co2_of_non_energetic_and_delayed_emissions, which is now split into separate queries for non energetic and delayed emissions. Therefore, the notes should refer toprimary_co2_of_non_energetic. - 3rd sentence: change beginning of the sentence to 'this node's primary CO2 emissions will at...'
There was a problem hiding this comment.
Few comments regarding query notes:
- the part referring to delayed emissions should be removed
- change the last sentence to refer to the specific group and sector, such as 'non-energetic final demand of group co2_emissions_refinery_products in the industry sector is not (yet) included in this query, which currently only consists of non-energetic methanol final demand. Since its free_co2_factor is 1.0, the method of querying this node currenlty doesn't affect the results'.
- Make sure to break a sentence to the next line when it gets too long, currently the case for the last sentence
There was a problem hiding this comment.
I'm not sure I understand this added sentence correctly, can you explain this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the non-energetic and delayed emissions in the co2 chart.
In addition, some documentation about the modeling choices cocnerning non energetic final demand of methanol is added.
Goes together with:
quintel/documentation#213
quintel/etmodel#4388