Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running upgrade command, ignore errors upgrading sources if outside of a git repository #1196

Merged
merged 4 commits into from
Nov 21, 2024
Merged

When running upgrade command, ignore errors upgrading sources if outside of a git repository #1196

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
513cbc1
Do not run source upgrade if upgrading CLI
noahd1 Nov 21, 2024
af7aa2c
Revert "Do not run source upgrade if upgrading CLI"
noahd1 Nov 21, 2024
84a7983
Do not propogate error from source upgrade
noahd1 Nov 21, 2024
b39e6b8
Merge branch 'main' into nd-source-upgrade
noahd1 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qlty-cli/src/commands/upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ impl Upgrade {
self.install(&executable_path)?;
}

SourceUpgrade::new().run()?;
SourceUpgrade::new().run().ok();

self.install_completions().ok();
self.print_result(&timer, &release);
Expand Down
Loading